Skip to content

Unittest fixes #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexanderoster merged 2 commits into from
Nov 10, 2025
Merged

Unittest fixes #45

alexanderoster merged 2 commits into from
Nov 10, 2025

Conversation

@krixkrix
Copy link

@krixkrix krixkrix commented Oct 31, 2025

Fixing all unit tests except the "XMLDocument" domain.

Before fixes:
Success rate 75% (69 of 91)

After fixes:
Success rate 86% (83 of 96)

  • Fixed SignalSlot tests
  • Fixed AccessControl tests

I don't know how to fix the XMLDocument tests.

===

Original test output:

$ ./amc_unittest 
----------------------------------------------------------------------------------
Autodesk Machine Control Unit Testing Framework
----------------------------------------------------------------------------------
Using core git hash f7c73db6...
   1 | XMLDocument            | ChangeNamespacePrefix               [ SUCCESS ]
   2 | XMLDocument            | CreateEmptyDocument                 [ SUCCESS ]
   3 | XMLDocument            | DuplicateNamespacePrefixShouldThr   [ SUCCESS ]
       Condition was not true (Exception must be thrown for inval   [ ERROR   ] 
   4 | XMLDocument            | InvalidNamespaceShouldThrow         [ FAILURE ]
   5 | XMLDocument            | ParseInvalidXMLShouldThrow          [ SUCCESS ]
   6 | XMLDocument            | ParseValidXML                       [ SUCCESS ]
   7 | XMLDocument            | RegisterAndFindNamespace            [ SUCCESS ]
   8 | XMLDocument            | SaveAndReloadXML                    [ SUCCESS ]
   9 | XMLDocumentNode        | AddAndFindAttribute                 [ SUCCESS ]
  10 | XMLDocumentNode        | AddAndFindChildNode                 [ SUCCESS ]
  11 | XMLDocumentNode        | AddAndRemoveAttribute               [ SUCCESS ]
       XML Node has text content                                    [ ERROR   ] 
  12 | XMLDocumentNode        | AddChildFailsWithTextContent        [ FAILURE ]
  13 | XMLDocumentNode        | AddDuplicateChildShouldNotThrow     [ SUCCESS ]
  14 | XMLDocumentNode        | ChildCountTracking                  [ SUCCESS ]
       Condition was not false                                      [ ERROR   ] 
  15 | XMLDocumentNode        | ChildMapIntegrityAfterRemovals      [ FAILURE ]
       Could not find XML Namespace: http://wrong.com (478) (478)   [ ERROR   ] 
  16 | XMLDocumentNode        | CompareNameLogic                    [ FAILURE ]
       XML Node has children                                        [ ERROR   ] 
  17 | XMLDocumentNode        | CopyDeepNode                        [ FAILURE ]
  18 | XMLDocumentNode        | CopyNodeContent                     [ SUCCESS ]
  19 | XMLDocumentNode        | CountChildrenByName                 [ SUCCESS ]
       Condition was not true (Copying nodes between documents sh   [ ERROR   ] 
  20 | XMLDocumentNode        | CrossDocumentCopyShouldThrow        [ FAILURE ]
       Duplicate attribute.: id (472) (472)                         [ ERROR   ] 
  21 | XMLDocumentNode        | DuplicateAttributeShouldFail        [ FAILURE ]
  22 | XMLDocumentNode        | GetPrefixedNameNoPrefix             [ SUCCESS ]
       Invalid attribute index.: 0 (467) (467)                      [ ERROR   ] 
  23 | XMLDocumentNode        | InvalidAttributeIndex               [ FAILURE ]
  24 | XMLDocumentNode        | InvalidParamShouldThrow             [ SUCCESS ]
  25 | XMLDocumentNode        | NamespacePrefixConflictShouldThro   [ SUCCESS ]
       Condition was not true                                       [ ERROR   ] 
  26 | XMLDocumentNode        | PrefixedNodeAndAttributeNames       [ FAILURE ]
  27 | XMLDocumentNode        | RemoveAttributeAfterCopy            [ SUCCESS ]
  28 | XMLDocumentNode        | RemoveAttributeByIndex              [ SUCCESS ]
       Condition was not false                                      [ ERROR   ] 
  29 | XMLDocumentNode        | RemoveChildPointer                  [ FAILURE ]
  30 | XMLDocumentNode        | RemoveChildrenByName                [ SUCCESS ]
  31 | XMLDocumentNode        | RemoveNonexistentAttribute          [ SUCCESS ]
       XML Node has children                                        [ ERROR   ] 
  32 | XMLDocumentNode        | SetTextContentFailWithChildren      [ FAILURE ]
  33 | XMLDocumentNode        | SetTextContentSuccess               [ SUCCESS ]
  34 | XMLDocumentNode        | SplitNamespaceName                  [ SUCCESS ]
  35 | XMLDocumentNode        | StoreToPugiXML                      [ SUCCESS ]
  36 | XMLDocumentNode        | TextContentClearsChildrenShouldFa   [ SUCCESS ]
  37 | XMLDocumentAttribute   | AttributeBoundToCorrectNode         [ SUCCESS ]
  38 | XMLDocumentAttribute   | AttributeNameCaseSensitive          [ SUCCESS ]
       could not parse XML String.                                  [ ERROR   ] 
  39 | XMLDocumentAttribute   | AttributeSerializationRoundtrip     [ FAILURE ]
  40 | XMLDocumentAttribute   | CreateAndRetrieveAttribute          [ SUCCESS ]
  41 | XMLDocumentAttribute   | EmptyValueIsAccepted                [ SUCCESS ]
  42 | XMLDocumentAttribute   | FuzzedAttributeValues               [ SUCCESS ]
  43 | XMLDocumentAttribute   | InvalidNamespaceShouldThrow         [ SUCCESS ]
  44 | XMLDocumentAttribute   | LongAttributeValue                  [ SUCCESS ]
  45 | XMLDocumentAttribute   | PrefixedNameDifferentNamespace      [ SUCCESS ]
       XML namespace already registered.: http://example.com (462   [ ERROR   ] 
  46 | XMLDocumentAttribute   | PrefixedNameSameNamespace           [ FAILURE ]
  47 | XMLDocumentAttribute   | SetAndGetValue                      [ SUCCESS ]
  48 | XMLDocumentAttribute   | SpecialCharacterValue               [ SUCCESS ]
  49 | XMLDocumentNamespace   | ChangePrefixToEmpty                 [ SUCCESS ]
  50 | XMLDocumentNamespace   | CheckXMLNameValidationNegative      [ SUCCESS ]
  51 | XMLDocumentNamespace   | CreateNamespaceAndReadBack          [ SUCCESS ]
  52 | XMLDocumentNamespace   | CreateWithEmptyNamespace            [ SUCCESS ]
  53 | XMLDocumentNamespace   | CreateWithLongPrefixAndNamespace    [ SUCCESS ]
  54 | XMLDocumentNamespace   | EqualityCheckByPointer              [ SUCCESS ]
  55 | XMLDocumentNamespace   | HasPrefixDetection                  [ SUCCESS ]
  56 | XMLDocumentNamespace   | IntegrationWithNodePrefixedAttrib   [ SUCCESS ]
  57 | XMLDocumentNamespace   | MultiplePrefixChanges               [ SUCCESS ]
  58 | XMLDocumentNamespace   | PrefixIsNotCopiedByReference        [ SUCCESS ]
  59 | XMLDocumentNamespace   | PrefixMutation                      [ SUCCESS ]
  60 | XMLDocumentNamespace   | SamePrefixDifferentNamespace        [ SUCCESS ]
  61 | XMLDocumentNamespace   | StaticChecksReturnTrue              [ SUCCESS ]
  62 | AccessControl          | AddAndFindRole                      [ SUCCESS ]
       Invalid access permission identifier: perm.read (518) (518   [ ERROR   ] 
  63 | AccessControl          | AddDuplicatePermissionFails         [ FAILURE ]
  64 | AccessControl          | AddDuplicateRoleFails               [ SUCCESS ]
       Invalid access permission identifier: perm.read (518) (518   [ ERROR   ] 
  65 | AccessControl          | AddPermission                       [ FAILURE ]
       Invalid access permission identifier: perm.test (518) (518   [ ERROR   ] 
  66 | AccessControl          | CheckPermissionInRole               [ FAILURE ]
  67 | AccessControl          | DefaultRoleNotSetThrows             [ SUCCESS ]
       Invalid access permission identifier: perm.view (518) (518   [ ERROR   ] 
  68 | AccessControl          | EmptyIdentifierThrows               [ FAILURE ]
  69 | AccessControl          | PermissionNotFoundThrows            [ SUCCESS ]
  70 | AccessControl          | SetDefaultRole                      [ SUCCESS ]
  71 | AccessControl          | SetToNoAccessControl                [ SUCCESS ]
  72 | AccessRole             | AddNullPermissionThrows             [ SUCCESS ]
  73 | AccessRole             | AddPermissionToRole                 [ SUCCESS ]
  74 | AccessRole             | CreateInvalidRoleThrows             [ SUCCESS ]
  75 | AccessRole             | CreateValidRole                     [ SUCCESS ]
  76 | AccessRole             | DuplicatePermissionThrows           [ SUCCESS ]
  77 | AccessRole             | GetPermissionsList                  [ SUCCESS ]
  78 | AccessRole             | RemovePermission                    [ SUCCESS ]
  79 | AccessPermission       | AccessorsReturnExpectedValues       [ SUCCESS ]
  80 | AccessPermission       | CreateValidPermission               [ SUCCESS ]
  81 | AccessPermission       | EmptyIdentifierThrows               [ SUCCESS ]
  82 | AccessPermission       | InvalidIdentifierThrows             [ SUCCESS ]
  83 | SignalSlot             | AddSignalToQueue                    [ SUCCESS ]
       invalid uuid string one                                      [ ERROR   ] 
  84 | SignalSlot             | ClearQueueWorks                     [ FAILURE ]
  85 | SignalSlot             | CreateSignalSlotBasic               [ SUCCESS ]
       invalid uuid string testuuid                                 [ ERROR   ] 
  86 | SignalSlot             | ParameterResultAccess               [ FAILURE ]
       invalid uuid string uuid-a                                   [ ERROR   ] 
  87 | SignalSlot             | PeekQueue                           [ FAILURE ]
       invalid uuid string uuid1                                    [ ERROR   ] 
  88 | SignalSlot             | QueueOverflow                       [ FAILURE ]
  89 | SignalSlot             | SignalFailureTransition             [ SUCCESS ]
  90 | SignalSlot             | SignalPhaseTransition               [ SUCCESS ]
       invalid uuid string overflow-0                               [ ERROR   ] 
  91 | SignalSlot             | TimeoutAndOverflowTest              [ FAILURE ]
Success rate 75% (69 of 91)

@alexanderoster alexanderoster merged commit b3281e5 into alexanderoster:develop Nov 10, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexanderoster alexanderoster alexanderoster approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krixkrix @alexanderoster